Re: [PATCH v5 16/21] ppc4xx_sdram: Move ppc4xx DDR and DDR2 SDRAM controller models together

[Philippe Mathieu-Daudé]

Hi Zoltan,

On 18/9/22 22:24, BALATON Zoltan wrote:
> Move the PPC4xx DDR and DDR2 SDRAM contrller models into a new file
> called ppc4xx_sdram to separate from other device models and put them
> in one place allowing sharing some code between them.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/meson.build      |   3 +-
>   hw/ppc/ppc440_uc.c      | 332 -----------------
>   hw/ppc/ppc4xx_devs.c    | 414 ---------------------
>   hw/ppc/ppc4xx_sdram.c   | 771 ++++++++++++++++++++++++++++++++++++++++
>   include/hw/ppc/ppc4xx.h |  24 +-
>   5 files changed, 785 insertions(+), 759 deletions(-)

This seems a proper cleanup, but even using `git-diff 
--color-moved=dimmed-zebra` I'm having hard time reviewing this single
patch.
Looking at the changes in the ppc4xx_sdram_types[] array, it
seems we can be move one model at a time, right?

[...]
> +static const TypeInfo ppc4xx_sdram_types[] = {
> +    {
> +        .name           = TYPE_PPC4xx_SDRAM_DDR,
> +        .parent         = TYPE_PPC4xx_DCR_DEVICE,
> +        .instance_size  = sizeof(Ppc4xxSdramDdrState),
> +        .class_init     = ppc4xx_sdram_ddr_class_init,
> +    }, {
> +        .name           = TYPE_PPC4xx_SDRAM_DDR2,
> +        .parent         = TYPE_PPC4xx_DCR_DEVICE,
> +        .instance_size  = sizeof(Ppc4xxSdramDdr2State),
> +        .class_init     = ppc4xx_sdram_ddr2_class_init,
> +    }
> +};
> +
> +DEFINE_TYPES(ppc4xx_sdram_types)
[...]