[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/10] QAPI patches patches for 2022-09-07
From: |
Markus Armbruster |
Subject: |
Re: [PULL 00/10] QAPI patches patches for 2022-09-07 |
Date: |
Mon, 19 Sep 2022 13:39:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Gentle reminder, Victor :)
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Kevin Wolf <kwolf@redhat.com> writes:
>>
>>> Am 07.09.2022 um 17:03 hat Markus Armbruster geschrieben:
>>>> The following changes since commit
>>>> 946e9bccf12f2bcc3ca471b820738fb22d14fc80:
>>>>
>>>> Merge tag 'samuel-thibault' of https://people.debian.org/~sthibault/qemu
>>>> into staging (2022-09-06 08:31:24 -0400)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>> git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-09-07
>>>>
>>>> for you to fetch changes up to 6e7a37ffc230d06852f1a8893097331d39df77c9:
>>>>
>>>> qapi: fix examples of events missing timestamp (2022-09-07 15:10:13
>>>> +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> QAPI patches patches for 2022-09-07
>>>>
>>>> ----------------------------------------------------------------
>>>> Victor Toso (10):
>>>> qapi: fix example of query-ballon command
>>>> qapi: fix example of query-vnc command
>>>> qapi: fix example of query-dump-guest-memory-capability command
>>>> qapi: fix example of BLOCK_JOB_READY event
>>>> qapi: fix example of NIC_RX_FILTER_CHANGED event
>>>> qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event
>>>> qapi: fix example of MEM_UNPLUG_ERROR event
>>>> qapi: fix examples of blockdev-add with qcow2
>>>
>>> NACK, this patch is wrong.
>>>
>>> 'file' is a required member (defined in BlockdevOptionsGenericFormat),
>>> removing it makes the example invalid. 'data-file' is only an additional
>>> optional member to be used for external data files (i.e. when the guest
>>> data is kept separate from the metadata in the .qcow2 file).
>>
>> I'll respin with #8 dropped. Thank you!
>
> Too late, it's already merged.
>
> Victor, could you fix on top? Or would you like me to revert the patch?
- [PULL 10/10] qapi: fix examples of events missing timestamp, (continued)
- [PULL 10/10] qapi: fix examples of events missing timestamp, Markus Armbruster, 2022/09/07
- [PULL 05/10] qapi: fix example of NIC_RX_FILTER_CHANGED event, Markus Armbruster, 2022/09/07
- [PULL 02/10] qapi: fix example of query-vnc command, Markus Armbruster, 2022/09/07
- [PULL 08/10] qapi: fix examples of blockdev-add with qcow2, Markus Armbruster, 2022/09/07
- [PULL 01/10] qapi: fix example of query-ballon command, Markus Armbruster, 2022/09/07
- [PULL 04/10] qapi: fix example of BLOCK_JOB_READY event, Markus Armbruster, 2022/09/07
- [PULL 03/10] qapi: fix example of query-dump-guest-memory-capability command, Markus Armbruster, 2022/09/07
- Re: [PULL 00/10] QAPI patches patches for 2022-09-07, Kevin Wolf, 2022/09/08
Re: [PULL 00/10] QAPI patches patches for 2022-09-07, Stefan Hajnoczi, 2022/09/08