[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/39] fsdev/virtfs-proxy-helper: Use g_mkdir()
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH v2 09/39] fsdev/virtfs-proxy-helper: Use g_mkdir() |
Date: |
Tue, 20 Sep 2022 15:42:04 +0200 |
On Dienstag, 20. September 2022 12:31:29 CEST Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Use g_mkdir() to create a directory on all platforms.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
>
> Changes in v2:
> - Change to use g_mkdir()
>
> fsdev/virtfs-proxy-helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index 2dde27922f..5cafcd7703 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include <glib/gstdio.h>
> #include <sys/resource.h>
> #include <getopt.h>
> #include <syslog.h>
> @@ -639,7 +640,7 @@ static int do_create_others(int type, struct iovec
> *iovec) if (retval < 0) {
> goto err_out;
> }
> - retval = mkdir(path.data, mode);
> + retval = g_mkdir(path.data, mode);
> break;
> case T_SYMLINK:
> retval = proxy_unmarshal(iovec, offset, "ss", &oldpath, &path);
- Re: [PATCH v2 08/39] block/vvfat: Unify the mkdir() call, (continued)
- [PATCH v2 02/39] tests/qtest: i440fx-test: Rewrite create_blob_file() to be portable, Bin Meng, 2022/09/20
- [PATCH v2 10/39] hw/usb: dev-mtp: Use g_mkdir(), Bin Meng, 2022/09/20
- [PATCH v2 06/39] util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary files, Bin Meng, 2022/09/20
- [PATCH v2 07/39] tests: Avoid using hardcoded /tmp in test cases, Bin Meng, 2022/09/20
- [PATCH v2 09/39] fsdev/virtfs-proxy-helper: Use g_mkdir(), Bin Meng, 2022/09/20
- Re: [PATCH v2 09/39] fsdev/virtfs-proxy-helper: Use g_mkdir(),
Christian Schoenebeck <=
- [PATCH v2 11/39] tests/qtest: Skip running virtio-net-test cases that require socketpair() for win32, Bin Meng, 2022/09/20
- [PATCH v2 12/39] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only, Bin Meng, 2022/09/20
- [PATCH v2 13/39] tests/qtest: qmp-test: Skip running test_qmp_oob for win32, Bin Meng, 2022/09/20
- [PATCH v2 15/39] tests/qtest: libqtest: Adapt global_qtest declaration for win32, Bin Meng, 2022/09/20
- [PATCH v2 16/39] tests/qtest: Use send/recv for socket communication, Bin Meng, 2022/09/20
- [PATCH v2 14/39] accel/qtest: Implement a portable qtest accelerator, Bin Meng, 2022/09/20
- [PATCH v2 18/39] tests/qtest: libqtest: Install signal handler via signal(), Bin Meng, 2022/09/20