Re: [PATCH v2 10/66] target/arm: Remove is_subpage argument to pmsav8_mpu_lookup

[Peter Maydell]

On Mon, 22 Aug 2022 at 16:54, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This can be made redundant with result->page_size, by moving the basic
> set of page_size from get_phys_addr_pmsav8.  We still need to overwrite
> page_size when v8m_security_lookup signals a subpage.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> @@ -1722,7 +1722,7 @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t 
> address,
>      uint32_t addr_page_base = address & TARGET_PAGE_MASK;
>      uint32_t addr_page_limit = addr_page_base + (TARGET_PAGE_SIZE - 1);
>
> -    *is_subpage = false;
> +    result->page_size = TARGET_PAGE_SIZE;
>      result->phys = address;
>      result->prot = 0;
>      if (mregion) {

There's a comment just above this that needs updating:

     * We set is_subpage to true if the region hit doesn't cover the
     * entire TARGET_PAGE the address is within.

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM