Re: [PATCH v2 25/66] target/arm: Add is_secure parameter to do_ats_write

[Peter Maydell]

On Mon, 22 Aug 2022 at 16:54, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use get_phys_addr_with_secure directly.  This is the one place
> where the value of is_secure may not equal arm_is_secure(env).

Is there an implicit "for A-profile" here? Various of the
m_helper.c calls to get_phys_addr() still pass in an mmu_idx
requesting an access for a different security state to that
of the current state of the core, I think.

>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Other than the commit message,

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM