[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/15] tests/qtest: npcm7xx-emc-test: Skip checking MAC
From: |
Thomas Huth |
Subject: |
[PULL 04/15] tests/qtest: npcm7xx-emc-test: Skip checking MAC |
Date: |
Tue, 20 Sep 2022 17:35:01 +0200 |
From: Patrick Venture <venture@google.com>
The register tests walks all the registers to verify they are initially
0 when appropriate. However, if the MAC address is set in the register
space, this should not be checked against 0.
Reviewed-by: Hao Wu <wuhaotsh@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
Message-Id: <20220906163138.2831353-1-venture@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/npcm7xx_emc-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c
index c373d24e1e..b046f1d76a 100644
--- a/tests/qtest/npcm7xx_emc-test.c
+++ b/tests/qtest/npcm7xx_emc-test.c
@@ -381,7 +381,8 @@ static void test_init(gconstpointer test_data)
#undef CHECK_REG
- for (i = 0; i < NUM_CAMML_REGS; ++i) {
+ /* Skip over the MAC address registers, which is BASE+0 */
+ for (i = 1; i < NUM_CAMML_REGS; ++i) {
g_assert_cmpuint(emc_read(qts, mod, REG_CAMM_BASE + i * 2), ==,
0);
g_assert_cmpuint(emc_read(qts, mod, REG_CAML_BASE + i * 2), ==,
--
2.31.1
- [PULL 00/15] Testing, qga and misc patches, Thomas Huth, 2022/09/20
- [PULL 01/15] tests: mark io-command test as skipped if socat is missing, Thomas Huth, 2022/09/20
- [PULL 02/15] tests/vm: update NetBSD to 9.3, Thomas Huth, 2022/09/20
- [PULL 05/15] qtest/fuzz-lsi53c895a-test: set guest RAM to 2G, Thomas Huth, 2022/09/20
- [PULL 03/15] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build, Thomas Huth, 2022/09/20
- [PULL 06/15] tests: Fix error strings, Thomas Huth, 2022/09/20
- [PULL 04/15] tests/qtest: npcm7xx-emc-test: Skip checking MAC,
Thomas Huth <=
- [PULL 07/15] meson-build: Enable CONFIG_REPLICATION only when replication is set, Thomas Huth, 2022/09/20
- [PULL 10/15] bios-tables-test: Only run test for machine types compiled in, Thomas Huth, 2022/09/20
- [PULL 15/15] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources, Thomas Huth, 2022/09/20
- [PULL 12/15] tests: sb16 has both pc and q35 tests, Thomas Huth, 2022/09/20
- [PULL 14/15] qga: Replace 'blacklist' command line and config file options by 'block-rpcs', Thomas Huth, 2022/09/20
- [PULL 13/15] gitlab-ci: Update the FreeBSD 13 job from 13.0 to 13.1, Thomas Huth, 2022/09/20
- [PULL 11/15] tests: Only run intel-hda-tests if machine type is compiled in, Thomas Huth, 2022/09/20
- [PULL 09/15] bios-tables-test: Sort all x86_64 tests by machine type, Thomas Huth, 2022/09/20
- [PULL 08/15] bios-tables-test: Make oem-fields tests be consistent, Thomas Huth, 2022/09/20
- Re: [PULL 00/15] Testing, qga and misc patches, Stefan Hajnoczi, 2022/09/21