Re: [PATCH 4/4] target/m68k: always call gen_exit_tb() after writes to SR

[Philippe Mathieu-Daudé]

On 19/9/22 10:13, Richard Henderson wrote:
> On 9/18/22 00:29, Philippe Mathieu-Daudé wrote:
> > On 17/9/22 13:25, Mark Cave-Ayland wrote:
> > > Any write to SR can change the security state so always call 
> > > gen_exit_tb() when
> > > this occurs. In particular MacOS makes use of andiw/oriw in a few 
> > > places to
> > > handle the switch between user and supervisor mode.
> >
> > Shouldn't be safer to add the gen_exit_tb() call in gen_set_sr[_im]()?
>
> No.  For halt we need to raise EXCP_HLT.

Right, I should have looked at translate.c; I also noticed the ccr_only
flag. So:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>