[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/23] target/i386: Remove cur_eip argument to gen_excepti
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v2 03/23] target/i386: Remove cur_eip argument to gen_exception |
|
Date: |
Wed, 21 Sep 2022 13:51:16 +0200 |
On Tue, Sep 6, 2022 at 4:45 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 6/9/22 12:09, Richard Henderson wrote:
> > All callers pass s->base.pc_next - s->cs_base, which we can just
> > as well compute within the function. Note the special case of
> > EXCP_VSYSCALL in which s->cs_base didn't have the subtraction,
> > but cs_base is always zero in 64-bit mode, when vsyscall is used.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> > target/i386/tcg/translate.c | 26 +++++++++++++-------------
> > 1 file changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
- [PATCH v2 00/23] target/i386: pc-relative translation blocks, Richard Henderson, 2022/09/06
- [PATCH v2 07/23] target/i386: Introduce DISAS_EOB*, Richard Henderson, 2022/09/06
- [PATCH v2 02/23] target/i386: Return bool from disas_insn, Richard Henderson, 2022/09/06
- [PATCH v2 03/23] target/i386: Remove cur_eip argument to gen_exception, Richard Henderson, 2022/09/06
- [PATCH v2 18/23] target/i386: Use gen_jmp_rel for loop and jecxz insns, Richard Henderson, 2022/09/06
- [PATCH v2 01/23] target/i386: Remove pc_start, Richard Henderson, 2022/09/06
- [PATCH v2 14/23] target/i386: Truncate values for lcall_real to i32, Richard Henderson, 2022/09/06
- [PATCH v2 22/23] target/i386: Create gen_eip_cur, Richard Henderson, 2022/09/06
- [PATCH v2 23/23] target/i386: Enable TARGET_TB_PCREL, Richard Henderson, 2022/09/06