[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 21/23] target/i386: Use gen_jmp_rel for DISAS_TOO_MANY
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v2 21/23] target/i386: Use gen_jmp_rel for DISAS_TOO_MANY |
Date: |
Wed, 21 Sep 2022 15:11:15 +0200 |
On Tue, Sep 6, 2022 at 12:09 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> With gen_jmp_rel, we may chain between two translation blocks
> which may only be separated because of TB size limits.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/i386/tcg/translate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index 7a9e533c6e..97a5f7e432 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -8740,6 +8740,9 @@ static void i386_tr_tb_stop(DisasContextBase *dcbase,
> CPUState *cpu)
> case DISAS_NORETURN:
> break;
> case DISAS_TOO_MANY:
> + gen_update_cc_op(dc);
> + gen_jmp_rel(dc, MO_32, 0, 0);
> + break;
> case DISAS_EOB_NEXT:
> gen_update_cc_op(dc);
> gen_update_eip_cur(dc);
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
- Re: [PATCH v2 11/23] target/i386: Create cur_insn_len, cur_insn_len_i32, (continued)
- [PATCH v2 13/23] target/i386: Introduce DISAS_JUMP, Richard Henderson, 2022/09/06
- [PATCH v2 20/23] target/i386: Use gen_jmp_rel for gen_repz*, Richard Henderson, 2022/09/06
- [PATCH v2 16/23] target/i386: Use DISAS_TOO_MANY to exit after gen_io_start, Richard Henderson, 2022/09/06
- [PATCH v2 21/23] target/i386: Use gen_jmp_rel for DISAS_TOO_MANY, Richard Henderson, 2022/09/06
- Re: [PATCH v2 21/23] target/i386: Use gen_jmp_rel for DISAS_TOO_MANY,
Paolo Bonzini <=
- Re: [PATCH v2 00/23] target/i386: pc-relative translation blocks, Paolo Bonzini, 2022/09/21