qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/10] disas: use result of ->read_memory_func


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 03/10] disas: use result of ->read_memory_func
Date: Wed, 21 Sep 2022 19:37:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 21/9/22 18:07, Alex Bennée wrote:
This gets especially confusing if you start plugging in host addresses
from a trace and you wonder why the output keeps changing. Report when
read_memory_func fails instead of blindly disassembling the buffer
contents.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
  disas.c          | 20 ++++++-------
  disas/capstone.c | 73 ++++++++++++++++++++++++++++--------------------
  2 files changed, 53 insertions(+), 40 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]