Re: [PATCH v7 00/14] QMP/HMP: introduce 'dumpdtb'

[Philippe Mathieu-Daudé]

Hi Daniel,

On 8/9/22 21:40, Daniel Henrique Barboza wrote:
> Hi,
>
> This new version implements all change requests from the v6.
>
> - patch 5:
>    - change bamboo_load_device_tree() to use a MachineState pointer
> - patch 7:
>    - change xilinx_load_device_tree() to use a MachineState pointer
> - patch 14:
>    - placed SRST/ERST below the { }'s
>    - removed the '/tmp' reference in the command example
>    - removed all 'Requires libfdt' references
>    - changed qmp_dumpdtb() missing FDT error message to "This machine
>      doesn't have a FDT"
> - v6 link: https://lists.gnu.org/archive/html/qemu-devel/2022-09/msg00534.html
>
> Daniel Henrique Barboza (14):
>    hw/arm: do not free machine->fdt in arm_load_dtb()
>    hw/microblaze: set machine->fdt in microblaze_load_dtb()
>    hw/nios2: set machine->fdt in nios2_load_dtb()
>    hw/ppc: set machine->fdt in ppce500_load_device_tree()
>    hw/ppc: set machine->fdt in bamboo_load_device_tree()
>    hw/ppc: set machine->fdt in sam460ex_load_device_tree()
>    hw/ppc: set machine->fdt in xilinx_load_device_tree()
>    hw/ppc: set machine->fdt in pegasos2_machine_reset()
>    hw/ppc: set machine->fdt in pnv_reset()
>    hw/ppc: set machine->fdt in spapr machine
>    hw/riscv: set machine->fdt in sifive_u_machine_init()
>    hw/riscv: set machine->fdt in spike_board_init()
>    hw/xtensa: set machine->fdt in xtfpga_init()
>    qmp/hmp, device_tree.c: introduce dumpdtb


- What about the MIPS Boston machine?

- We need to free ms->fdt in machine_finalize().