Re: [PATCH 14/27] qapi migration: Elide redundant has_FOO in generated C

[Daniel P . Berrangé]

On Thu, Sep 22, 2022 at 12:28:55PM +0100, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (armbru@redhat.com) wrote:
> > The has_FOO for pointer-valued FOO are redundant, except for arrays.
> > They are also a nuisance to work with.  Recent commit "qapi: Start to
> > elide redundant has_FOO in generated C" provided the means to elide
> > them step by step.  This is the step for qapi/migration.json.
> > 
> > Said commit explains the transformation in more detail.  The invariant
> > violations mentioned there do not occur here.
> > 
> > Cc: Juan Quintela <quintela@redhat.com>
> > Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> 
> Yeh I'm OK with that, I do hate the has_'s:
> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Just cc'd in Dan though, wasn't there something special about the TLS
> options?

Yes, some of them use StrOrNull rather than just 'str', but I think
the change is OK

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|