[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Only generate cluster node in PPTT when specified
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH 0/4] Only generate cluster node in PPTT when specified |
Date: |
Thu, 22 Sep 2022 15:31:28 +0100 |
On Thu, 22 Sep 2022 21:11:39 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> This series mainly change the policy for building a cluster topology node
> in PPTT. Previously we'll always build a cluster node in PPTT without
> asking the user, after this set the cluster node will be built only the
> the user specify through "-smp clusters=X".
>
> Update the tests and test tables accordingly.
Hi Yicong,
Does this bring an issue with backwards compatibility?
I'm assuming we need to make this something controlled in
virt_machine_7_1_options()?
One of those things we probably should have noticed originally but now
we are stuck with the slightly messy backwards compatibility problem.
Also, looks like you picked up a bunch of tables that are unrelated
to the change.
Jonathan
>
> Yicong Yang (4):
> hw/acpi/aml-build: Only generate cluster node in PPTT when specified
> tests: virt: update expected ACPI tables for virt test
> tests: acpi: aarch64: add topology test for aarch64
> tests: acpi: aarch64: add *.topology tables
>
> hw/acpi/aml-build.c | 2 +-
> hw/core/machine-smp.c | 3 +++
> include/hw/boards.h | 2 ++
> tests/data/acpi/virt/APIC.pxb | Bin 0 -> 168 bytes
> tests/data/acpi/virt/APIC.topology | Bin 0 -> 700 bytes
> tests/data/acpi/virt/DBG2.memhp | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.numamem | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.pxb | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DBG2.topology | Bin 0 -> 87 bytes
> tests/data/acpi/virt/DSDT.topology | Bin 0 -> 5398 bytes
> tests/data/acpi/virt/FACP.pxb | Bin 0 -> 268 bytes
> tests/data/acpi/virt/FACP.topology | Bin 0 -> 268 bytes
> tests/data/acpi/virt/GTDT.pxb | Bin 0 -> 96 bytes
> tests/data/acpi/virt/GTDT.topology | Bin 0 -> 96 bytes
> tests/data/acpi/virt/IORT.topology | Bin 0 -> 128 bytes
> tests/data/acpi/virt/MCFG.pxb | Bin 0 -> 60 bytes
> tests/data/acpi/virt/MCFG.topology | Bin 0 -> 60 bytes
> tests/data/acpi/virt/PPTT | Bin 96 -> 76 bytes
> tests/data/acpi/virt/PPTT.memhp | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.numamem | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.pxb | Bin 0 -> 76 bytes
> tests/data/acpi/virt/PPTT.topology | Bin 0 -> 336 bytes
> tests/data/acpi/virt/SPCR.pxb | Bin 0 -> 80 bytes
> tests/data/acpi/virt/SPCR.topology | Bin 0 -> 80 bytes
> tests/qtest/bios-tables-test.c | 22 ++++++++++++++++++++++
> 25 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 tests/data/acpi/virt/APIC.pxb
> create mode 100644 tests/data/acpi/virt/APIC.topology
> create mode 100644 tests/data/acpi/virt/DBG2.memhp
> create mode 100644 tests/data/acpi/virt/DBG2.numamem
> create mode 100644 tests/data/acpi/virt/DBG2.pxb
> create mode 100644 tests/data/acpi/virt/DBG2.topology
> create mode 100644 tests/data/acpi/virt/DSDT.topology
> create mode 100644 tests/data/acpi/virt/FACP.pxb
> create mode 100644 tests/data/acpi/virt/FACP.topology
> create mode 100644 tests/data/acpi/virt/GTDT.pxb
> create mode 100644 tests/data/acpi/virt/GTDT.topology
> create mode 100644 tests/data/acpi/virt/IORT.topology
> create mode 100644 tests/data/acpi/virt/MCFG.pxb
> create mode 100644 tests/data/acpi/virt/MCFG.topology
> create mode 100644 tests/data/acpi/virt/PPTT.memhp
> create mode 100644 tests/data/acpi/virt/PPTT.numamem
> create mode 100644 tests/data/acpi/virt/PPTT.pxb
> create mode 100644 tests/data/acpi/virt/PPTT.topology
> create mode 100644 tests/data/acpi/virt/SPCR.pxb
> create mode 100644 tests/data/acpi/virt/SPCR.topology
>