[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] migration: Disallow xbzrle with postcopy
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 3/5] migration: Disallow xbzrle with postcopy |
Date: |
Thu, 22 Sep 2022 16:56:21 +0100 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
* Peter Xu (peterx@redhat.com) wrote:
> It's not supported since the 1st day, as ram_load_postcopy does not handle
> RAM_SAVE_FLAG_XBZRLE. Mark it disabled explicitly.
We've already got a check in ram_save_page:
if (rs->xbzrle_enabled && !migration_in_postcopy()) {
pages = save_xbzrle_page(rs, &p, current_addr, block,
offset);
so that's supposed to allow you to enable xbzrle with postcopy and take
advantage of xbzrle during the precopy phase.
Dave
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/migration.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index bb8bbddfe4..fb4066dfb4 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1268,6 +1268,11 @@ static bool migrate_caps_check(bool *cap_list,
> error_setg(errp, "Postcopy is not compatible with
> ignore-shared");
> return false;
> }
> +
> + if (cap_list[MIGRATION_CAPABILITY_XBZRLE]) {
> + error_setg(errp, "Postcopy is not compatible with xbzrle");
> + return false;
> + }
> }
>
> if (cap_list[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT]) {
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
[PATCH 1/5] migration: Fix possible deadloop of ram save process, Peter Xu, 2022/09/20