[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: unmap (discard) blocks only if discard_zeros flag is
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH] block: unmap (discard) blocks only if discard_zeros flag is true |
|
Date: |
Fri, 23 Sep 2022 16:28:14 +0200 |
Am 23.09.2022 um 12:02 hat luzhipeng geschrieben:
> From: lu zhipeng <luzhipeng@cestc.cn>
>
> we can unmap(discard) blocks for block devices of supporting discard zeros
> or regular file.
>
> Signed-off-by: lu zhipeng <luzhipeng@cestc.cn>
This more or less restores the state before commit 34fa110e. The commit
message there explains that s->discard_zeroes is unreliable (in
particular, it is false on block devices on recent kernels even though
they may support zeroing by discard just fine).
We should instead remove s->discard_zeroes because it is currently
unused. I'll send a patch.
Kevin