qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] block: unmap (discard) blocks only if discard_zeros flag is


From: luzhipeng
Subject: Re: [PATCH] block: unmap (discard) blocks only if discard_zeros flag is true
Date: Fri, 23 Sep 2022 22:33:31 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0



在 2022/9/23 22:28, Kevin Wolf 写道:
Am 23.09.2022 um 12:02 hat luzhipeng geschrieben:
From: lu zhipeng <luzhipeng@cestc.cn>

we can unmap(discard) blocks for block devices of supporting discard zeros
or regular file.

Signed-off-by: lu zhipeng <luzhipeng@cestc.cn>

This more or less restores the state before commit 34fa110e. The commit
message there explains that s->discard_zeroes is unreliable (in
particular, it is false on block devices on recent kernels even though
they may support zeroing by discard just fine).

We should instead remove s->discard_zeroes because it is currently
unused. I'll send a patch.

Kevin



OK





reply via email to

[Prev in Thread] Current Thread [Next in Thread]