Re: [PATCH v11 03/15] target/hexagon: make slot number an unsigned

[Philippe Mathieu-Daudé]

On 4/8/22 13:55, Anton Johansson via wrote:
> From: Paolo Montesel <babush@rev.ng>
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Paolo Montesel <babush@rev.ng>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   target/hexagon/genptr.c | 24 +++++++++++++-----------
>   target/hexagon/macros.h |  2 +-
>   2 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
> index 8a334ba07b..6741278ada 100644
> --- a/target/hexagon/genptr.c
> +++ b/target/hexagon/genptr.c
> @@ -30,7 +30,8 @@
>   #include "gen_tcg.h"
>   #include "gen_tcg_hvx.h"
>   
> -static inline void gen_log_predicated_reg_write(int rnum, TCGv val, int slot)
> +static inline void gen_log_predicated_reg_write(int rnum, TCGv val,
> +                                                uint32_t slot)

Using 'unsigned' would keep consistency with the rest of the codebase.

Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>