Re: [PATCH v2 25/37] target/i386: clarify (un)signedness of immediates from 0F3Ah opcodes

[Richard Henderson]

On 9/20/22 17:24, Paolo Bonzini wrote:
> Three-byte opcodes from the 0F3Ah area all have an immediate byte which
> is usually unsigned.  Clarify in the helper code that it is unsigned;
> the new decoder treats immediates as signed by default, and seeing
> an intN_t in the prototype might give the wrong impression that one
> can use decode->immediate directly.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   target/i386/ops_sse.h        | 8 ++++----
>   target/i386/ops_sse_header.h | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~