[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/54] tests/qtest: virtio_blk_fuzz: Avoid using hardcoded /tm
From: |
Bin Meng |
Subject: |
[PATCH v3 11/54] tests/qtest: virtio_blk_fuzz: Avoid using hardcoded /tmp |
Date: |
Sun, 25 Sep 2022 19:29:49 +0800 |
From: Bin Meng <bin.meng@windriver.com>
This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_file_open_tmp() for a portable implementation.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
Changes in v3:
- Split to a separate patch
tests/qtest/fuzz/virtio_blk_fuzz.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/fuzz/virtio_blk_fuzz.c
b/tests/qtest/fuzz/virtio_blk_fuzz.c
index 236d078cc8..a9fb9ecf6c 100644
--- a/tests/qtest/fuzz/virtio_blk_fuzz.c
+++ b/tests/qtest/fuzz/virtio_blk_fuzz.c
@@ -181,10 +181,10 @@ static void drive_destroy(void *path)
static char *drive_create(void)
{
int fd, ret;
- char *t_path = g_strdup("/tmp/qtest.XXXXXX");
+ char *t_path;
/* Create a temporary raw image */
- fd = mkstemp(t_path);
+ fd = g_file_open_tmp("qtest.XXXXXX", &t_path, NULL);
g_assert_cmpint(fd, >=, 0);
ret = ftruncate(fd, TEST_IMAGE_SIZE);
g_assert_cmpint(ret, ==, 0);
--
2.34.1
- [PATCH v3 20/54] tests/qtest: virtio-scsi-test: Avoid using hardcoded /tmp, (continued)
- [PATCH v3 20/54] tests/qtest: virtio-scsi-test: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 27/54] hw/usb: dev-mtp: Use g_mkdir(), Bin Meng, 2022/09/25
- [PATCH v3 23/54] tests/unit: test-qga: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 21/54] tests/qtest: libqtest: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 25/54] block/vvfat: Unify the mkdir() call, Bin Meng, 2022/09/25
- [PATCH v3 31/54] accel/qtest: Implement a portable qtest accelerator, Bin Meng, 2022/09/25
- [PATCH v3 26/54] fsdev/virtfs-proxy-helper: Use g_mkdir(), Bin Meng, 2022/09/25
- [PATCH v3 11/54] tests/qtest: virtio_blk_fuzz: Avoid using hardcoded /tmp,
Bin Meng <=
- [PATCH v3 28/54] tests/qtest: Skip running virtio-net-test cases that require socketpair() for win32, Bin Meng, 2022/09/25
- [PATCH v3 29/54] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only, Bin Meng, 2022/09/25
- [PATCH v3 24/54] tests: vhost-user-bridge: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 22/54] tests/unit: test-image-locking: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 18/54] tests/qtest: vhost-user-test: Avoid using hardcoded /tmp, Bin Meng, 2022/09/25
- [PATCH v3 30/54] tests/qtest: qmp-test: Skip running test_qmp_oob for win32, Bin Meng, 2022/09/25