Re: [PATCH 2/7] linux-user: Add proper strace format strings for getdents()/getdents64()

[Laurent Vivier]

Le 24/09/2022 à 13:44, Helge Deller a écrit :
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   linux-user/strace.list | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index da8c1bf34e..bfef568d18 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -285,10 +285,10 @@
>   { TARGET_NR_getcwd, "getcwd" , "%s(%p,%d)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_getdents
> -{ TARGET_NR_getdents, "getdents" , NULL, NULL, NULL },
> +{ TARGET_NR_getdents, "getdents" , "%s(%d,%p,%u)", NULL, NULL },
>   #endif
>   #ifdef TARGET_NR_getdents64
> -{ TARGET_NR_getdents64, "getdents64" , NULL, NULL, NULL },
> +{ TARGET_NR_getdents64, "getdents64" , "%s(%d,%p,%u)", NULL, NULL },

3rd argument is a size_t.
I think it should be TARGET_ABI_FMT_lu.

Thanks,
Laurent
>   #endif
>   #ifdef TARGET_NR_getdomainname
>   { TARGET_NR_getdomainname, "getdomainname" , NULL, NULL, NULL },
> --
> 2.37.3