Re: [PATCH] gtk: Add show_menubar=on|off command line option.

[Markus Armbruster]

Bryce Mills <brycemills@proton.me> writes:

> The patch adds "show_menubar" command line option for GTK UI similar to
> "show_tabs". This option allows to hide menu bar initially, it still can
> be toggled by shortcut and other shortcuts still work.
>
> (First-time contributor)
>
> Signed-off-by: Bryce Mills <brycemills@proton.me>
> ---
>  qapi/ui.json    |  6 +++++-
>  qemu-options.hx |  4 +++-
>  ui/gtk.c        | 15 ++++++++++-----
>  3 files changed, 18 insertions(+), 7 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 286c5731d1..124975d724 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -1200,12 +1200,16 @@
>  #               by default.
>  #               Since 7.1
>  #
> +# @show-menubar:  Display the main window menubar
> +#                 Since 8.0

Please mention the default.

Not your patch's fault: @grab-on-hover and @show-tabs should mention
their default.

> +#
>  # Since: 2.12
>  ##
>  { 'struct'  : 'DisplayGTK',
>    'data'    : { '*grab-on-hover' : 'bool',
>                  '*zoom-to-fit'   : 'bool',
> -                '*show-tabs'     : 'bool'  } }
> +                '*show-tabs'     : 'bool',
> +                '*show-menubar'  : 'bool'  } }
>
>  ##
>  # @DisplayEGLHeadless:

[...]