[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 07/16] net: stream: Don't ignore EINVAL on netdev socket conne
From: |
Laurent Vivier |
Subject: |
[PATCH v9 07/16] net: stream: Don't ignore EINVAL on netdev socket connection |
Date: |
Mon, 26 Sep 2022 21:50:39 +0200 |
From: Stefano Brivio <sbrivio@redhat.com>
Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
net/stream.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/stream.c b/net/stream.c
index e71c120ac379..3fb899df5d2d 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -363,8 +363,7 @@ static int net_stream_client_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");
--
2.37.3
- [PATCH v9 00/16] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/09/26
- [PATCH v9 08/16] net: stream: add unix socket, Laurent Vivier, 2022/09/26
- [PATCH v9 06/16] net: socket: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/09/26
- [PATCH v9 02/16] net: remove the @errp argument of net_client_inits(), Laurent Vivier, 2022/09/26
- [PATCH v9 07/16] net: stream: Don't ignore EINVAL on netdev socket connection,
Laurent Vivier <=
- [PATCH v9 05/16] qapi: net: add stream and dgram netdevs, Laurent Vivier, 2022/09/26
- [PATCH v9 03/16] net: simplify net_client_parse() error management, Laurent Vivier, 2022/09/26
- [PATCH v9 04/16] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/09/26
- [PATCH v9 14/16] net: stream: move to QIO to enable additional parameters, Laurent Vivier, 2022/09/26
- [PATCH v9 15/16] tests/qtest: netdev: test stream and dgram backends, Laurent Vivier, 2022/09/26
- [PATCH v9 13/16] qemu-sockets: update socket_uri() and socket_parse() to be consistent, Laurent Vivier, 2022/09/26