RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

[Ji, Ruili]

[AMD Official Use Only - General]

Hi Anthony,

You could change the mail name as following:

Signed-off-by: Aaron Liu <Aaron.Liu@amd.com>
Signed-off-by: Ruili Ji <ruili.ji@amd.com>

Thank you very much for your help! 😊
Ruili
-----Original Message-----
From: Anthony PERARD <anthony.perard@citrix.com>
Sent: 2022年9月26日 23:12
To: Ji, Ruili <Ruili.Ji@amd.com>
Cc: qemu-devel@nongnu.org; Liu, Aaron <Aaron.Liu@amd.com>
Subject: Re: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


On Tue, Sep 06, 2022 at 07:40:25AM +0000, Ji, Ruili wrote:
> From: Ruili Ji ruili.ji@amd.com<mailto:ruili.ji@amd.com>
> Date: Tue, 6 Sep 2022 14:09:41 +0800
> Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough
> device
>
> Make guest os access pci device control 2 reg for passthrough device
> as struct XenPTRegInfo described in the file hw/xen/xen_pt.h.
> /* reg read only field mask (ON:RO/ROS, OFF:other) */ uint32_t
> ro_mask;
> /* reg emulate field mask (ON:emu, OFF:passthrough) */ uint32_t
> emu_mask;
>
> Resolves:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> ab.com%2Fqemu-project%2Fqemu%2F-%2Fissues%2F1196&amp;data=05%7C01%7CRu
> ili.Ji%40amd.com%7Ce82b40622815465f75f008da9fd18957%7C3dd8961fe4884e60
> 8e11a82d994e183d%7C0%7C0%7C637998019556415690%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%7C%7C&amp;sdata=kvIFi4yDM2%2BMUsIkuaNJeqc0C6ePsIlfqj1pSkzIZqM%3
> D&amp;reserved=0
> Signed-off-by: Aaron.Liu@amd.com<mailto:Aaron.Liu@amd.com>
> Signed-off-by: ruili.ji@amd.com<mailto:ruili.ji@amd.com>

Hi Ruili,

I believe both signed-off-by line aren't formatted as expected (I think a name 
is needed with the email address), may I change them to:

  Signed-off-by: Aaron Lui <Aaron.Liu@amd.com>
  Signed-off-by: Ruili Ji <ruili.ji@amd.com>

The second line would be the same as the author of the patch (From:).

Thanks,

--
Anthony PERARD