[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iom
From: |
Jean-Philippe Brucker |
Subject: |
[PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node |
Date: |
Tue, 27 Sep 2022 11:03:48 +0100 |
The "PCI Bus Binding to: IEEE Std 1275-1994" defines the compatible
string for a PCIe bus or endpoint as "pci<vendorid>,<deviceid>" or
similar. Since the initial binding for PCI virtio-iommu didn't follow
this rule, it was modified to accept both strings and ensure backward
compatibility. Also, the unit-name for the node should be
"device,function".
Fix corresponding dt-validate and dtc warnings:
pcie@10000000: virtio_iommu@16:compatible: ['virtio,pci-iommu'] does not
contain items matching the given schema
pcie@10000000: Unevaluated properties are not allowed (... 'virtio_iommu@16'
were unexpected)
From schema: linux/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
virtio_iommu@16: compatible: 'oneOf' conditional failed, one must be fixed:
['virtio,pci-iommu'] is too short
'pci1af4,1057' was expected
From schema: dtschema/schemas/pci/pci-bus.yaml
Warning (pci_device_reg): /pcie@10000000/virtio_iommu@16: PCI unit address
format error, expected "2,0"
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
hw/arm/virt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 2de16f6324..5e16d54bbb 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -1372,14 +1372,15 @@ static void create_smmu(const VirtMachineState *vms,
static void create_virtio_iommu_dt_bindings(VirtMachineState *vms)
{
- const char compat[] = "virtio,pci-iommu";
+ const char compat[] = "virtio,pci-iommu\0pci1af4,1057";
uint16_t bdf = vms->virtio_iommu_bdf;
MachineState *ms = MACHINE(vms);
char *node;
vms->iommu_phandle = qemu_fdt_alloc_phandle(ms->fdt);
- node = g_strdup_printf("%s/virtio_iommu@%d", vms->pciehb_nodename, bdf);
+ node = g_strdup_printf("%s/virtio_iommu@%x,%x", vms->pciehb_nodename,
+ PCI_SLOT(bdf), PCI_FUNC(bdf));
qemu_fdt_add_subnode(ms->fdt, node);
qemu_fdt_setprop(ms->fdt, node, "compatible", compat, sizeof(compat));
qemu_fdt_setprop_sized_cells(ms->fdt, node, "reg",
--
2.37.3
- Re: [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI, (continued)
- [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node,
Jean-Philippe Brucker <=
- [PATCH v2 8/8] hw/arm/virt: Fix devicetree warnings about node names, Jean-Philippe Brucker, 2022/09/27
- Re: [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings, Peter Maydell, 2022/09/29