qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] audio: improve out.voices test


From: Marc-André Lureau
Subject: Re: [PATCH 2/2] audio: improve out.voices test
Date: Tue, 27 Sep 2022 15:27:09 +0400

Hi

On Sun, Sep 25, 2022 at 1:05 PM Helge Konetzka <hk@zapateado.de> wrote:

Improve readability of audio out.voices test:
If 1 is logged and set after positive test, 1 should be tested.

Signed-off-by: Helge Konetzka <hk@zapateado.de>

That's not helping much, but why not. I'll let Gerd decide.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

 
---
  audio/audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/audio/audio.c b/audio/audio.c
index 8a0ade4052..912b456058 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1750,7 +1750,7 @@ static AudioState *audio_init(Audiodev *dev, const
char *name)
      s->nb_hw_voices_out = audio_get_pdo_out(dev)->voices;
      s->nb_hw_voices_in = audio_get_pdo_in(dev)->voices;

-    if (s->nb_hw_voices_out <= 0) {
+    if (s->nb_hw_voices_out < 1) {
          dolog ("Bogus number of playback voices %d, setting to 1\n",
                 s->nb_hw_voices_out);
          s->nb_hw_voices_out = 1;
--
2.37.3



--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]