[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/5] module: add Error arguments to module_load and module
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom |
Date: |
Tue, 27 Sep 2022 13:57:19 +0200 |
Am 27.09.2022 um 09:54 hat Markus Armbruster geschrieben:
> Potential issue before this patch: I can't see bdrv_open_child() being
> undone. Shouldn't we close bs->file? And what about
> bdrv_open_child()'s side effect on @options?
bs->file is handled by the caller, bdrv_open_driver().
options is going to be freed anyway, so I don't think we care about its
content. And anyway, doesn't bdrv_open_child() only remove those entries
from it that it processed, like in the success case?
Kevin
- [PATCH v6 4/5] dmg: warn when opening dmg images containing blocks of unknown type, (continued)
- [PATCH v6 4/5] dmg: warn when opening dmg images containing blocks of unknown type, Claudio Fontana, 2022/09/23
- [PATCH v6 1/5] module: removed unused function argument "mayfail", Claudio Fontana, 2022/09/23
- [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Claudio Fontana, 2022/09/23
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Kevin Wolf, 2022/09/26
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Claudio Fontana, 2022/09/26
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Claudio Fontana, 2022/09/26
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Markus Armbruster, 2022/09/27
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Claudio Fontana, 2022/09/27
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Kevin Wolf, 2022/09/27
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom, Claudio Fontana, 2022/09/27
- Re: [PATCH v6 3/5] module: add Error arguments to module_load and module_load_qom,
Kevin Wolf <=
[PATCH v6 5/5] accel: abort if we fail to load the accelerator plugin, Claudio Fontana, 2022/09/23