qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 12/54] tests/qtest: hd-geo-test: Avoid using hardcoded /tm


From: Thomas Huth
Subject: Re: [PATCH v4 12/54] tests/qtest: hd-geo-test: Avoid using hardcoded /tmp
Date: Tue, 27 Sep 2022 14:21:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 27/09/2022 13.05, Bin Meng wrote:
From: Bin Meng <bin.meng@windriver.com>

This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_file_open_tmp() for a portable implementation.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

Changes in v4:
- Do not use g_autofree and g_steal_pointer

Changes in v3:
- Split to a separate patch
- Ensure g_autofree variable is initialized
- Use g_steal_pointer() in create_test_img()

  tests/qtest/hd-geo-test.c | 24 +++++++++++-------------
  1 file changed, 11 insertions(+), 13 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]