[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root no
From: |
Eric Auger |
Subject: |
Re: [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node |
Date: |
Tue, 27 Sep 2022 14:48:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
Hi jean,
On 9/27/22 12:03, Jean-Philippe Brucker wrote:
> The devicetree specification requires a 'model' property in the root
> node. Fix the corresponding dt-validate warning:
>
> /: 'model' is a required property
> From schema: dtschema/schemas/root-node.yaml
>
> Use the same name for model as for compatible. The specification
> recommends that 'compatible' follows the format 'manufacturer,model' and
> 'model' follows the format 'manufacturer,model-number'. Since our>
> 'compatible' doesn't observe this, 'model' doesn't really need to
> either.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Eric
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 1a6480fd2a..83ab1a37fb 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -252,6 +252,7 @@ static void create_fdt(VirtMachineState *vms)
> qemu_fdt_setprop_string(fdt, "/", "compatible", "linux,dummy-virt");
> qemu_fdt_setprop_cell(fdt, "/", "#address-cells", 0x2);
> qemu_fdt_setprop_cell(fdt, "/", "#size-cells", 0x2);
> + qemu_fdt_setprop_string(fdt, "/", "model", "linux,dummy-virt");
>
> /* /chosen must exist for load_dtb to fill in necessary properties later
> */
> qemu_fdt_add_subnode(fdt, "/chosen");
- Re: [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI, (continued)
- [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 8/8] hw/arm/virt: Fix devicetree warnings about node names, Jean-Philippe Brucker, 2022/09/27
- Re: [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings, Peter Maydell, 2022/09/29