[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU no
From: |
Eric Auger |
Subject: |
Re: [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU node |
Date: |
Tue, 27 Sep 2022 15:24:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
Hi Jean,
you may add: as opposed to SMMUv2, ...
> The SMMUv3 node isn't expected to have clock properties. Fix the
> corresponding dt-validate warning:
>
> smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema: linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks!
Eric
> ---
> hw/arm/virt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 10ce66c722..2de16f6324 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1362,8 +1362,6 @@ static void create_smmu(const VirtMachineState *vms,
> qemu_fdt_setprop(ms->fdt, node, "interrupt-names", irq_names,
> sizeof(irq_names));
>
> - qemu_fdt_setprop_cell(ms->fdt, node, "clocks", vms->clock_phandle);
> - qemu_fdt_setprop_string(ms->fdt, node, "clock-names", "apb_pclk");
> qemu_fdt_setprop(ms->fdt, node, "dma-coherent", NULL, 0);
>
> qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1);
- [PATCH v2 0/8] hw/arm/virt: Fix dt-schema warnings, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 5/8] hw/arm/virt: Fix devicetree warnings about the GPIO node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 6/8] hw/arm/virt: Fix devicetree warning about the SMMU node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 3/8] hw/arm/virt: Use "msi-map" devicetree property for PCI, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 2/8] hw/arm/virt: Fix devicetree warning about the GIC node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 4/8] hw/arm/virt: Fix devicetree warning about the gpio-key node, Jean-Philippe Brucker, 2022/09/27
- [PATCH v2 1/8] hw/arm/virt: Fix devicetree warning about the root node, Jean-Philippe Brucker, 2022/09/27