[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/15] target/arm: ensure ptw accesses set appropriate MemTxAt
From: |
Alex Bennée |
Subject: |
[PATCH v3 05/15] target/arm: ensure ptw accesses set appropriate MemTxAttrs |
Date: |
Tue, 27 Sep 2022 15:14:54 +0100 |
While mapping your page table base to the GICs address space would be
an "interesting" design choice the resultant loads would still be CPU
initiated so should be tagged as such.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
target/arm/ptw.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index 4b0dc9bd14..62d32d660a 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -252,7 +252,7 @@ static uint32_t arm_ldl_ptw(CPUARMState *env, hwaddr addr,
bool is_secure,
ARMMMUIdx mmu_idx, ARMMMUFaultInfo *fi)
{
CPUState *cs = env_cpu(env);
- MemTxAttrs attrs = {};
+ MemTxAttrs attrs = MEMTXATTRS_CPU(cs);
MemTxResult result = MEMTX_OK;
AddressSpace *as;
uint32_t data;
@@ -280,7 +280,7 @@ static uint64_t arm_ldq_ptw(CPUARMState *env, hwaddr addr,
bool is_secure,
ARMMMUIdx mmu_idx, ARMMMUFaultInfo *fi)
{
CPUState *cs = env_cpu(env);
- MemTxAttrs attrs = {};
+ MemTxAttrs attrs = MEMTXATTRS_CPU(cs);
MemTxResult result = MEMTX_OK;
AddressSpace *as;
uint64_t data;
@@ -2289,8 +2289,8 @@ bool get_phys_addr(CPUARMState *env, target_ulong address,
ARMMMUIdx s1_mmu_idx = stage_1_mmu_idx(mmu_idx);
bool is_secure = regime_is_secure(env, mmu_idx);
- attrs->requester_type = MEMTXATTRS_CPU;
- attrs->requester_id = env_cpu(env)->cpu_index;
+ result->attrs.requester_type = MTRT_CPU;
+ result->attrs.requester_id = env_cpu(env)->cpu_index;
if (mmu_idx != s1_mmu_idx) {
/*
--
2.34.1
- [PATCH v3 00/15] gdbstub/next (MemTxAttrs, re-factoring), Alex Bennée, 2022/09/27
- [PATCH v3 01/15] hw: encode accessing CPU index in MemTxAttrs, Alex Bennée, 2022/09/27
- [PATCH v3 02/15] target/arm: ensure TCG IO accesses set appropriate MemTxAttrs, Alex Bennée, 2022/09/27
- [PATCH v3 03/15] target/arm: ensure HVF traps set appropriate MemTxAttrs, Alex Bennée, 2022/09/27
- [PATCH v3 08/15] hw/intc/gic: use MxTxAttrs to divine accessing CPU, Alex Bennée, 2022/09/27
- [PATCH v3 05/15] target/arm: ensure ptw accesses set appropriate MemTxAttrs,
Alex Bennée <=
- [PATCH v3 10/15] configure: move detected gdb to TCG's config-host.mak, Alex Bennée, 2022/09/27
- [PATCH v3 04/15] target/arm: ensure KVM traps set appropriate MemTxAttrs, Alex Bennée, 2022/09/27
- [PATCH v3 07/15] qtest: make read/write operation appear to be from CPU, Alex Bennée, 2022/09/27
- [PATCH v3 06/15] target/arm: ensure m-profile helpers set appropriate MemTxAttrs, Alex Bennée, 2022/09/27
- [PATCH v3 09/15] hw/timer: convert mptimer access to attrs to derive cpu index, Alex Bennée, 2022/09/27