Re: [PATCH v4 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32

[Marc-André Lureau]

On Tue, Sep 27, 2022 at 6:38 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Tue, Sep 27, 2022 at 10:33 PM Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
> >
> > On Tue, Sep 27, 2022 at 3:09 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > From: Bin Meng <bin.meng@windriver.com>
> > >
> > > Some migration test cases use TLS to communicate, but they fail on
> > > Windows with the following error messages:
> > >
> > >   qemu-system-x86_64: TLS handshake failed: Insufficient credentials for 
> > > that request.
> > >   qemu-system-x86_64: TLS handshake failed: Error in the pull function.
> > >   query-migrate shows failed migration: TLS handshake failed: Error in 
> > > the pull function.
> > >
> > > Disable them temporarily.
> > >
> > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > > ---
> > > I am not familar with the gnutls and simply enabling the gnutls debug
> > > output does not give me an immedidate hint on why it's failing on
> > > Windows. Disable these cases for now until someone or maintainers
> > > who may want to test this on Windows.
> > >
> > > (no changes since v1)
> >
> > Please use g_test_skip() instead of #if blocks.
> >
>
> Is there a QEMU API to detect OS?

You can use #ifdef WIN32 for that, but don't comment out code that
compiles and should be "fixed".

>
> Regards,
> Bin
>