qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 35/54] tests/qtest: libqtest: Install signal handler via s


From: Thomas Huth
Subject: Re: [PATCH v4 35/54] tests/qtest: libqtest: Install signal handler via signal()
Date: Wed, 28 Sep 2022 12:03:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 28/09/2022 11.57, Bin Meng wrote:
On Wed, Sep 28, 2022 at 5:43 PM Thomas Huth <thuth@redhat.com> wrote:

On 27/09/2022 13.06, Bin Meng wrote:
From: Bin Meng <bin.meng@windriver.com>

At present the codes uses sigaction() to install signal handler with
a flag SA_RESETHAND. Such usage can be covered by the signal() API
that is a simplified interface to the general sigaction() facility.

Update to use signal() to install the signal handler, as it is
available on Windows which we are going to support.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---

(no changes since v1)

   tests/qtest/libqtest.c | 14 +++-----------
   1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 269d622fe3..f0ac467903 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -66,7 +66,7 @@ struct QTestState
   };

   static GHookList abrt_hooks;
-static struct sigaction sigact_old;
+static sighandler_t sighandler_old;

This seems to break compilation on NetBSD (which you can test via "make
vm-build-netbsd" on a Linux KVM host):

Oops, so this means this test is not covered by GitLab CI ...

You can enable the NetBSD tests in the Gitlab-CI by setting up Cirrus-CI for your account. The information hides here:

 .gitlab-ci.d/cirrus/README.rst

... but since this is running NetBSD in a KVM-enabled container on Cirrus-CI via a script from Gitlab-CI, it's a little bit fragile, so it might be easier to simply type "make vm-build-netbsd" on your local KVM-capable Linux host.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]