Re: [patch v0] qapi/qmp: Add timestamps to qmp command responses.

[Daniel P . Berrangé]

On Wed, Sep 28, 2022 at 04:24:29PM +0600, Roman Kagan wrote:
> On Tue, Sep 27, 2022 at 08:04:11AM +0200, Markus Armbruster wrote:
> > Daniel P. Berrangé <berrange@redhat.com> writes:
> > > On Mon, Sep 26, 2022 at 12:59:40PM +0300, Denis Plotnikov wrote:
> > >> Example of result:
> > >> 
> > >>     ./qemu/scripts/qmp/qmp-shell /tmp/qmp.socket
> > >> 
> > >>     (QEMU) query-status
> > >>     {"end": {"seconds": 1650367305, "microseconds": 831032},
> > >>      "start": {"seconds": 1650367305, "microseconds": 831012},
> > >>      "return": {"status": "running", "singlestep": false, "running": 
> > >> true}}
> > >> 
> > >> The responce of the qmp command contains the start & end time of
> > >> the qmp command processing.
> > 
> > Seconds and microseconds since when?  The update to qmp-spec.txt should
> > tell.
> > 
> > Why split the time into seconds and microseconds?
> 
> This is exactly how timestamps in QMP events are done, so we thought
> we'd just follow suit

Yes, I think its good to have consistency with the rest of the spec,
despite Markus' point that it could be simplified to one field.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|