Re: [PULL 00/38] Linux user for 7.2 patches

[Laurent Vivier]

Le 28/09/2022 à 22:04, Stefan Hajnoczi a écrit :
> Hi Laurent,
> There is a build failure for hexagon linux-user. Please take a look (I
> didn't verify whether it's caused by your pull request, but I think
> the chance is high):
>
> cc -m64 -mcx16 -Ilibqemu-hexagon-linux-user.fa.p -I. -I..
> -Itarget/hexagon -I../target/hexagon -I../common-user/host/x86_64
> -I../linux-user/include/host/x86_64 -I../linux-user/include
> -Ilinux-user -I../linux-user -I../linux-user/hexagon -Iqapi -Itrace
> -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fdiagnostics-color=auto
> -Wall -Winvalid-pch -Werror -std=gnu11 -O2 -g -isystem
> /builds/qemu-project/qemu/linux-headers -isystem linux-headers -iquote
> . -iquote /builds/qemu-project/qemu -iquote
> /builds/qemu-project/qemu/include -iquote
> /builds/qemu-project/qemu/tcg/i386 -pthread -U_FORTIFY_SOURCE
> -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef
> -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common
> -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
> -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined
> -Wimplicit-fallthrough=2 -Wno-missing-include-dirs
> -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE
> -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H
> '-DCONFIG_TARGET="hexagon-linux-user-config-target.h"'
> '-DCONFIG_DEVICES="hexagon-linux-user-config-devices.h"' -MD -MQ
> libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o -MF
> libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o.d -o
> libqemu-hexagon-linux-user.fa.p/linux-user_strace.c.o -c
> ../linux-user/strace.c
> ../linux-user/strace.c: In function 'print_syscall':
> ../linux-user/strace.c:3931:23: error: implicit declaration of
> function 'gettid'; did you mean 'getgid'?
> [-Werror=implicit-function-declaration]
> fprintf(f, "%d ", gettid());
> ^~~~~~
> getgid
> ../linux-user/strace.c:3931:23: error: nested extern declaration of
> 'gettid' [-Werror=nested-externs]

It's patch 37/38 "linux-user: Log tid for strace", I think.

I'm going to remove it.

Thanks,
Laurent