[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/17] accel/tcg: Suppress auto-invalidate in probe_access
From: |
Alex Bennée |
Subject: |
Re: [PATCH v5 03/17] accel/tcg: Suppress auto-invalidate in probe_access_internal |
Date: |
Thu, 29 Sep 2022 12:49:55 +0100 |
User-agent: |
mu4e 1.9.0; emacs 28.2.50 |
Richard Henderson <richard.henderson@linaro.org> writes:
> When PAGE_WRITE_INV is set when calling tlb_set_page,
> we immediately set TLB_INVALID_MASK in order to force
> tlb_fill to be called on the next lookup. Here in
> probe_access_internal, we have just called tlb_fill
> and eliminated true misses, thus the lookup must be valid.
>
> This allows us to remove a warning comment from s390x.
> There doesn't seem to be a reason to change the code though.
>
> Cc: David Hildenbrand <david@redhat.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH v5 00/17] tcg: CPUTLBEntryFull and TARGET_TB_PCREL, Richard Henderson, 2022/09/25
- [PATCH v5 01/17] accel/tcg: Rename CPUIOTLBEntry to CPUTLBEntryFull, Richard Henderson, 2022/09/25
- [PATCH v5 02/17] accel/tcg: Drop addr member from SavedIOTLB, Richard Henderson, 2022/09/25
- [PATCH v5 03/17] accel/tcg: Suppress auto-invalidate in probe_access_internal, Richard Henderson, 2022/09/25
- [PATCH v5 04/17] accel/tcg: Introduce probe_access_full, Richard Henderson, 2022/09/25
- [PATCH v5 05/17] accel/tcg: Introduce tlb_set_page_full, Richard Henderson, 2022/09/25
- [PATCH v5 06/17] include/exec: Introduce TARGET_PAGE_ENTRY_EXTRA, Richard Henderson, 2022/09/25
- [PATCH v5 07/17] target/sparc: Use tlb_set_page_full, Richard Henderson, 2022/09/25
- [PATCH v5 08/17] accel/tcg: Move byte_swap from MemTxAttrs to CPUTLBEntryFull, Richard Henderson, 2022/09/25