Re: [PULL 00/10] QAPI patches patches for 2022-09-07

[Markus Armbruster]

Markus Armbruster <armbru@redhat.com> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>
>> Gentle reminder, Victor :)
>>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Markus Armbruster <armbru@redhat.com> writes:
>>>
>>>> Kevin Wolf <kwolf@redhat.com> writes:
>>>>
>>>>> Am 07.09.2022 um 17:03 hat Markus Armbruster geschrieben:
>>>>>> The following changes since commit 
>>>>>> 946e9bccf12f2bcc3ca471b820738fb22d14fc80:
>
> [...]
>
>>>>>>       qapi: fix examples of blockdev-add with qcow2
>>>>>
>>>>> NACK, this patch is wrong.
>>>>>
>>>>> 'file' is a required member (defined in BlockdevOptionsGenericFormat),
>>>>> removing it makes the example invalid. 'data-file' is only an additional
>>>>> optional member to be used for external data files (i.e. when the guest
>>>>> data is kept separate from the metadata in the .qcow2 file).
>>>>
>>>> I'll respin with #8 dropped.  Thank you!
>>>
>>> Too late, it's already merged.
>>>
>>> Victor, could you fix on top?  Or would you like me to revert the patch?
>
> Revert posted: 
>
>     Subject: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"
>     Date: Fri, 30 Sep 2022 17:26:34 +0200
>     Message-Id: <20220930152634.774907-1-armbru@redhat.com>

I messed up the send.  Correction is
Message-Id: <20220930171908.846769-1-armbru@redhat.com>