qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granu


From: Richard Henderson
Subject: Re: [PATCH 1/2] target/arm: Don't allow guest to use unimplemented granule sizes
Date: Fri, 30 Sep 2022 13:14:40 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/30/22 10:48, Peter Maydell wrote:
@@ -10289,20 +10289,113 @@ static int aa64_va_parameter_tcma(uint64_t tcr, 
ARMMMUIdx mmu_idx)
      }
  }
+typedef enum GranuleSize {
+    /* Same order as TG0 encoding */
+    Gran4K,
+    Gran64K,
+    Gran16K,
+    GranInvalid,
+} GranuleSize;

It might be worth using this in ARMVAParameters. Even if you don't do that now, it would be worth putting this typedef in internals.h.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]