[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 0/2] qemu-thread: Strict unlock check
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH RFC 0/2] qemu-thread: Strict unlock check |
|
Date: |
Wed, 12 Oct 2022 14:16:44 -0400 |
On Tue, Oct 11, 2022 at 06:41:52PM -0400, Peter Xu wrote:
> NOTE: mark patchset RFC because "make check" will easily fail; but I didn't
> yet dig into why as I'm not familiar with the code paths that triggers, it
> can be bugs hidden or something I missed. So RFC to just have some thoughts.
I just noticed (after reminded from Dave) that the reclock was actually the
recursive lock, which definitely won't work with patch 2 at all.
OTOH I also noticed PTHREAD_MUTEX_ERRORCHECK which does the same unlock
check that we can leverage (and it'll also check re-lock from the same
thread which causes deadlock). I'll give that a shot instead.
Please ignore this version. Patch 1 is still meaningful I think, but
anyway I'll repost. Sorry for the noise.
--
Peter Xu