[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 29/53] tcg/s390x: Convert tcg_out_qemu_{ld,st}_slow_path
From: |
Richard Henderson |
Subject: |
[PULL 29/53] tcg/s390x: Convert tcg_out_qemu_{ld,st}_slow_path |
Date: |
Thu, 11 May 2023 09:04:26 +0100 |
Use tcg_out_ld_helper_args, tcg_out_ld_helper_ret,
and tcg_out_st_helper_args.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/s390x/tcg-target.c.inc | 35 ++++++++++-------------------------
1 file changed, 10 insertions(+), 25 deletions(-)
diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc
index c3157d22be..dfcf4d9e34 100644
--- a/tcg/s390x/tcg-target.c.inc
+++ b/tcg/s390x/tcg-target.c.inc
@@ -1718,26 +1718,22 @@ static void tcg_out_qemu_st_direct(TCGContext *s, MemOp
opc, TCGReg data,
}
#if defined(CONFIG_SOFTMMU)
+static const TCGLdstHelperParam ldst_helper_param = {
+ .ntmp = 1, .tmp = { TCG_TMP0 }
+};
+
static bool tcg_out_qemu_ld_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
{
- TCGReg addr_reg = lb->addrlo_reg;
- TCGReg data_reg = lb->datalo_reg;
- MemOpIdx oi = lb->oi;
- MemOp opc = get_memop(oi);
+ MemOp opc = get_memop(lb->oi);
if (!patch_reloc(lb->label_ptr[0], R_390_PC16DBL,
(intptr_t)tcg_splitwx_to_rx(s->code_ptr), 2)) {
return false;
}
- tcg_out_mov(s, TCG_TYPE_PTR, TCG_REG_R2, TCG_AREG0);
- if (TARGET_LONG_BITS == 64) {
- tcg_out_mov(s, TCG_TYPE_I64, TCG_REG_R3, addr_reg);
- }
- tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_R4, oi);
- tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_R5, (uintptr_t)lb->raddr);
- tcg_out_call_int(s, qemu_ld_helpers[opc & (MO_BSWAP | MO_SSIZE)]);
- tcg_out_mov(s, TCG_TYPE_I64, data_reg, TCG_REG_R2);
+ tcg_out_ld_helper_args(s, lb, &ldst_helper_param);
+ tcg_out_call_int(s, qemu_ld_helpers[opc & (MO_BSWAP | MO_SIZE)]);
+ tcg_out_ld_helper_ret(s, lb, false, &ldst_helper_param);
tgen_gotoi(s, S390_CC_ALWAYS, lb->raddr);
return true;
@@ -1745,25 +1741,14 @@ static bool tcg_out_qemu_ld_slow_path(TCGContext *s,
TCGLabelQemuLdst *lb)
static bool tcg_out_qemu_st_slow_path(TCGContext *s, TCGLabelQemuLdst *lb)
{
- TCGReg addr_reg = lb->addrlo_reg;
- TCGReg data_reg = lb->datalo_reg;
- MemOpIdx oi = lb->oi;
- MemOp opc = get_memop(oi);
- MemOp size = opc & MO_SIZE;
+ MemOp opc = get_memop(lb->oi);
if (!patch_reloc(lb->label_ptr[0], R_390_PC16DBL,
(intptr_t)tcg_splitwx_to_rx(s->code_ptr), 2)) {
return false;
}
- tcg_out_mov(s, TCG_TYPE_PTR, TCG_REG_R2, TCG_AREG0);
- if (TARGET_LONG_BITS == 64) {
- tcg_out_mov(s, TCG_TYPE_I64, TCG_REG_R3, addr_reg);
- }
- tcg_out_movext(s, size == MO_64 ? TCG_TYPE_I64 : TCG_TYPE_I32,
- TCG_REG_R4, lb->type, size, data_reg);
- tcg_out_movi(s, TCG_TYPE_I32, TCG_REG_R5, oi);
- tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_R6, (uintptr_t)lb->raddr);
+ tcg_out_st_helper_args(s, lb, &ldst_helper_param);
tcg_out_call_int(s, qemu_st_helpers[opc & (MO_BSWAP | MO_SIZE)]);
tgen_gotoi(s, S390_CC_ALWAYS, lb->raddr);
--
2.34.1
- [PULL 36/53] tcg/ppc: Remove unused constraints A, B, C, D, (continued)
- [PULL 36/53] tcg/ppc: Remove unused constraints A, B, C, D, Richard Henderson, 2023/05/11
- [PULL 16/53] tcg/mips: Introduce prepare_host_addr, Richard Henderson, 2023/05/11
- [PULL 38/53] tcg/riscv: Simplify constraints on qemu_ld/st, Richard Henderson, 2023/05/11
- [PULL 23/53] tcg/aarch64: Convert tcg_out_qemu_{ld,st}_slow_path, Richard Henderson, 2023/05/11
- [PULL 39/53] tcg/s390x: Use ALGFR in constructing softmmu host address, Richard Henderson, 2023/05/11
- [PULL 20/53] tcg: Add routines for calling slow-path helpers, Richard Henderson, 2023/05/11
- [PULL 19/53] tcg/s390x: Introduce prepare_host_addr, Richard Henderson, 2023/05/11
- [PULL 28/53] tcg/riscv: Convert tcg_out_qemu_{ld,st}_slow_path, Richard Henderson, 2023/05/11
- [PULL 27/53] tcg/ppc: Convert tcg_out_qemu_{ld,st}_slow_path, Richard Henderson, 2023/05/11
- [PULL 30/53] tcg/loongarch64: Simplify constraints on qemu_ld/st, Richard Henderson, 2023/05/11
- [PULL 29/53] tcg/s390x: Convert tcg_out_qemu_{ld,st}_slow_path,
Richard Henderson <=
- [PULL 24/53] tcg/arm: Convert tcg_out_qemu_{ld,st}_slow_path, Richard Henderson, 2023/05/11
- [PULL 03/53] disas: Fix tabs and braces in disas.c, Richard Henderson, 2023/05/11
- [PULL 35/53] tcg/ppc: Adjust constraints on qemu_ld/st, Richard Henderson, 2023/05/11
- [PULL 37/53] tcg/ppc: Remove unused constraint J, Richard Henderson, 2023/05/11
- [PULL 32/53] tcg/mips: Reorg tlb load within prepare_host_addr, Richard Henderson, 2023/05/11
- [PULL 40/53] tcg/s390x: Simplify constraints on qemu_ld/st, Richard Henderson, 2023/05/11
- [PULL 42/53] target/mips: Add missing default_tcg_memop_mask, Richard Henderson, 2023/05/11
- [PULL 41/53] target/mips: Add MO_ALIGN to gen_llwp, gen_scwp, Richard Henderson, 2023/05/11
- [PULL 44/53] target/mips: Remove TARGET_ALIGNED_ONLY, Richard Henderson, 2023/05/11
- [PULL 43/53] target/mips: Use MO_ALIGN instead of 0, Richard Henderson, 2023/05/11