[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/5] python/qmp/legacy: allow using sockets for connect()
From: |
John Snow |
Subject: |
[PATCH 2/5] python/qmp/legacy: allow using sockets for connect() |
Date: |
Wed, 17 May 2023 12:34:03 -0400 |
Instead of asserting that we have an address, allow the use of sockets
instead of addresses during a call to connect().
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/qmp/legacy.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/python/qemu/qmp/legacy.py b/python/qemu/qmp/legacy.py
index 8b09ee7dbb..b1eb3f360f 100644
--- a/python/qemu/qmp/legacy.py
+++ b/python/qemu/qmp/legacy.py
@@ -150,12 +150,13 @@ def connect(self, negotiate: bool = True) ->
Optional[QMPMessage]:
:return: QMP greeting dict, or None if negotiate is false
:raise ConnectError: on connection errors
"""
- assert self._address is not None
+ addr_or_sock = self._address or self._sock
+ assert addr_or_sock is not None
self._qmp.await_greeting = negotiate
self._qmp.negotiate = negotiate
self._sync(
- self._qmp.connect(self._address)
+ self._qmp.connect(addr_or_sock)
)
return self._get_greeting()
--
2.40.0
- [PATCH 0/5] python: backport socket changes from python-qemu-qmp, John Snow, 2023/05/17
- [PATCH 1/5] python/qmp: allow sockets to be passed to connect(), John Snow, 2023/05/17
- [PATCH 3/5] python/machine: use connect-based interface for existing sockets, John Snow, 2023/05/17
- [PATCH 4/5] python/qmp/legacy: remove open_with_socket() calls, John Snow, 2023/05/17
- [PATCH 2/5] python/qmp/legacy: allow using sockets for connect(),
John Snow <=
- [PATCH 5/5] Revert "python/qmp/protocol: add open_with_socket()", John Snow, 2023/05/17
- Re: [PATCH 0/5] python: backport socket changes from python-qemu-qmp, John Snow, 2023/05/23