|
From: | Song Gao |
Subject: | Re: [PATCH 1/4] hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes |
Date: | Tue, 23 May 2023 09:25:20 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道:
On 22/5/23 13:47, Jiaxun Yang wrote:2023年5月22日 04:52,Huacai Chen <chenhuacai@kernel.org> 写道: Hi, Jiaxun, Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS and LoongArch in your series.Hi Huacai, Thanks for the point, what’s the opinion from LoongArch mainatiners? Or perhaps rename it as loong_ipi to reflect the nature that it’s shared by MIPS based Loongson and LoongArch based Loongson?I'm not a LoongArch maintainer, but a model named "loong_ipi" makes sense to me. Please add it to the two Virt machine sections in MAINTAINERS.
'loonggson_ipi' is better, qemu doesn't have naming with 'loong' as prefix.And patch2 should not use macros. Some attributes should be added to distinguish between MIPS and LongArch.
All references to loongarch_ipi should also be changed. Thanks. Song Gao
[Prev in Thread] | Current Thread | [Next in Thread] |