[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/15] tests/qtest/rtl8139-test: Check whether the rtl8139 device
From: |
Thomas Huth |
Subject: |
[PULL 10/15] tests/qtest/rtl8139-test: Check whether the rtl8139 device is available |
Date: |
Fri, 26 May 2023 11:08:35 +0200 |
Though we are already using CONFIG_RTL8139_PCI in the meson.build file
for testing whether the rtl8139 device is available or not, this is not
enough: The CONFIG switch might have been selected by another target
(e.g. the mips fuloong2e machine has the rtl8139 chip soldered on the
board), so CONFIG_RTL8139_PCI ends up in config_all_devices and the
test then gets executed on x86. We need an additional run-time check
to be on the safe side to make this test also work when configure has
been run with "--without-default-devices".
Message-Id: <20230525081016.1870364-4-thuth@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/rtl8139-test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c
index 4bd240e9ee..4dc0a0d22e 100644
--- a/tests/qtest/rtl8139-test.c
+++ b/tests/qtest/rtl8139-test.c
@@ -209,6 +209,10 @@ int main(int argc, char **argv)
g_test_init(&argc, &argv, NULL);
+ if (!qtest_has_device("rtl8139")) {
+ return 0;
+ }
+
qtest_start("-device rtl8139");
qtest_add_func("/rtl8139/nop", nop);
--
2.31.1
- [PULL 00/15] Improve --without-default-devices testing, fix CVE-2023-0330, Thomas Huth, 2023/05/26
- [PULL 02/15] hw/alpha: Use MachineClass->default_nic in the alpha machine, Thomas Huth, 2023/05/26
- [PULL 01/15] hw/hppa: Use MachineClass->default_nic in the hppa machine, Thomas Huth, 2023/05/26
- [PULL 04/15] hw/loongarch64: Use MachineClass->default_nic in the virt machine, Thomas Huth, 2023/05/26
- [PULL 03/15] hw/arm: Use MachineClass->default_nic in the virt machine, Thomas Huth, 2023/05/26
- [PULL 06/15] hw/arm: Use MachineClass->default_nic in the sbsa-ref machine, Thomas Huth, 2023/05/26
- [PULL 05/15] hw/xtensa: Use MachineClass->default_nic in the virt machine, Thomas Huth, 2023/05/26
- [PULL 08/15] tests/qtest/usb-hcd-uhci-test: Check whether "usb-storage" is available, Thomas Huth, 2023/05/26
- [PULL 10/15] tests/qtest/rtl8139-test: Check whether the rtl8139 device is available,
Thomas Huth <=
- [PULL 07/15] hw/mips: Use MachineClass->default_nic in the virt machine, Thomas Huth, 2023/05/26
- [PULL 09/15] tests/qtest: Check for virtio-blk before using -cdrom with the arm virt machine, Thomas Huth, 2023/05/26
- [PULL 11/15] tests/qtest/usb-hcd-ehci-test: Check for EHCI and UHCI HCDs before using them, Thomas Huth, 2023/05/26
- [PULL 13/15] machine: do not crash if default RAM backend name has been stolen, Thomas Huth, 2023/05/26
- [PULL 14/15] lsi53c895a: disable reentrancy detection for MMIO region, too, Thomas Huth, 2023/05/26
- [PULL 15/15] hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330), Thomas Huth, 2023/05/26
- [PULL 12/15] tests/qtest/ac97-test: add up-/downsampling tests, Thomas Huth, 2023/05/26
- Re: [PULL 00/15] Improve --without-default-devices testing, fix CVE-2023-0330, Richard Henderson, 2023/05/26