Re: [PATCH 3/5] meson: subprojects: replace submodules with wrap files

[Paolo Bonzini]

On Tue, May 30, 2023 at 2:24 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > +    if test -e "$source_path/.git"; then
> > +        echo "--disable-download specified but subprojects were not"
> > +        echo "checked out.  Please download subprojects."
>
> Building from tarball will be ok as we bundle everything affected. This
> errror will hit anyone building from git with --disable-download though.

Right, just like it hits people doing --with-git-submodule=ignore; but
you're right that --disable-download is more generic and therefore
this error is more likely to happen.

> How should developers/users download the subprojects ? Can we tell them
> what command is needed ?

For those that want to use --disable-download, I can include "meson
subprojects download" in the error message, e.g "Please invoke "meson
subprojects download" before configuring QEMU, or remove
--disable-download from the command line."

Paolo