Re: [PATCH 04/12] hw/ssi: Add an "addr" property to SSIPeripheral

[Cédric Le Goater]

On 5/30/23 22:33, Philippe Mathieu-Daudé wrote:
> On 8/5/23 09:58, Cédric Le Goater wrote:
> > Boards will use this new property to identify the device CS line and
> > wire the SPI controllers accordingly.
> >
> > Cc: Alistair Francis <alistair@alistair23.me>
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > ---
> >   include/hw/ssi/ssi.h | 3 +++
> >   hw/ssi/ssi.c         | 7 +++++++
> >   2 files changed, 10 insertions(+)
> >
> > diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h
> > index 6950f86810..ffd3a34ba4 100644
> > --- a/include/hw/ssi/ssi.h
> > +++ b/include/hw/ssi/ssi.h
> > @@ -64,6 +64,9 @@ struct SSIPeripheral {
> >       /* Chip select state */
> >       bool cs;
> > +
> > +    /* Chip select address/index */
> > +    uint32_t addr;
>
> uint8_t is probably enough.

Yes. A uint8_t is more than enough.

Thanks,

C.

 
> Otherwise,
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> >   };