Re: [PATCH v14 05/10] debug: add -d tb_stats to control TBStatistics collection:

[Wu, Fei]

On 6/1/2023 9:18 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> From: "Vanderson M. do Rosario" <vandersonmr2@gmail.com>
>>
>>   -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=<number>]]
>>
>> "dump_limit" is used to limit the number of dumped TBStats in
>> linux-user mode.
> 
> Why is user-mode special?
> 
Should be an issue in comment, not in code.

>>
>> [all+jit+exec+time] control the profilling level used
>> by the TBStats. Can be used as follow:
>>
>> -d tb_stats
>> -d tb_stats,level=jit+time
> 
> Comma is already used to separate different -d options.
> You should not overload that.
> 
> "level" doesn't make sense for things that aren't hierarchical.
> 
> What's wrong with tb-stats-{all,jit,time,exec}?
> 
Let me try.

Thanks,
Fei.
> 
> r~