[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/9] tests/qtest: add various qtest_qmp_assert_success() v
From: |
Juan Quintela |
Subject: |
Re: [PATCH v3 1/9] tests/qtest: add various qtest_qmp_assert_success() variants |
Date: |
Thu, 01 Jun 2023 14:04:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> wrote:
> Add several counterparts of qtest_qmp_assert_success() that can
>
> * Use va_list instead of ...
> * Accept a list of FDs to send
> * Return the response data
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qtest/libqtest.c | 99 +++++++++++++++++++++++++++++++++--
> tests/qtest/libqtest.h | 115 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 209 insertions(+), 5 deletions(-)
>
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index c3a0ef5bb4..603c26d955 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -1229,14 +1229,23 @@ void qtest_memset(QTestState *s, uint64_t addr,
> uint8_t pattern, size_t size)
> qtest_rsp(s);
> }
>
> -void qtest_qmp_assert_success(QTestState *qts, const char *fmt, ...)
> +void qtest_vqmp_assert_success(QTestState *qts,
> + const char *fmt, va_list args)
> {
> - va_list ap;
> QDict *response;
>
> - va_start(ap, fmt);
> - response = qtest_vqmp(qts, fmt, ap);
> - va_end(ap);
> + response = qtest_vqmp_assert_success_ref(qts, fmt, args);
> +
> + qobject_unref(response);
> +}
> +
> +QDict *qtest_vqmp_assert_success_ref(QTestState *qts,
> + const char *fmt, va_list args)
> +{
I was about to chime in that this two functions should be declared in
reverse and see that Thomas had the same ide.
Later, Juan