Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migra

From:	Juan Quintela
Subject:	Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test
Date:	Thu, 01 Jun 2023 14:17:51 +0200
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Daniel P. Berrangé <berrange@redhat.com> wrote:
> This function duplicates logic of qtest_qmp_assert_success_ref
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Much better that the current code.  And as you answer to Thomas, better
messages in case of errors.

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test, Thomas Huth, 2023/06/01
- Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test, Daniel P . Berrangé, 2023/06/01
- Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test, Juan Quintela <=

Prev by Date: [PATCH v3 10/10] memory-device: Track used region size in DeviceMemoryState
Next by Date: Re: [PATCH v3 1/9] tests/qtest: add various qtest_qmp_assert_success() variants
Previous by thread: Re: [PATCH v3 3/9] tests/qtest: get rid of 'qmp_command' helper in migration test
Next by thread: Re: [PATCH v3 4/9] tests/qtest: get rid of some 'qtest_qmp' usage in migration test
Index(es):
- Date
- Thread