[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] block: remove separate bdrv_file_open callback
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 0/3] block: remove separate bdrv_file_open callback |
Date: |
Thu, 1 Jun 2023 08:42:54 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Jun 01, 2023 at 01:51:36PM +0200, Paolo Bonzini wrote:
> The value of the bdrv_file_open is sometimes checked to distinguish
> protocol and format drivers, but apart from that there is no difference
> between bdrv_file_open and bdrv_open.
>
> However, they can all be distinguished by the non-NULL .protocol_name
> member. Change the checks to use .protocol_name instead of .bdrv_file_open,
> and unify the two callbacks.
>
> Paolo
>
> v1->v2: fix bisectability
>
> Paolo Bonzini (3):
> block: make assertion more generic
> block: do not check bdrv_file_open
> block: remove separate bdrv_file_open callback
Series:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org