[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] hw/net/virtio-net: make some VirtIONet const
From: |
Eugenio Perez Martin |
Subject: |
Re: [PATCH v3 3/6] hw/net/virtio-net: make some VirtIONet const |
Date: |
Thu, 1 Jun 2023 16:15:17 +0200 |
On Thu, Jun 1, 2023 at 3:49 PM Hawkins Jiawei <yin31149@gmail.com> wrote:
>
> The VirtIONet structure is not modified in
> virtio_net_supported_guest_offloads().
> Therefore, make it const to allow this function to
> accept const variables.
>
> Signed-off-by: Hawkins Jiawei <yin31149@gmail.com>
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> hw/net/virtio-net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 6df6b7329d..7b27dad6c4 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -874,7 +874,7 @@ static uint64_t
> virtio_net_guest_offloads_by_features(uint32_t features)
> return guest_offloads_mask & features;
> }
>
> -static inline uint64_t virtio_net_supported_guest_offloads(VirtIONet *n)
> +static inline uint64_t virtio_net_supported_guest_offloads(const VirtIONet
> *n)
> {
> VirtIODevice *vdev = VIRTIO_DEVICE(n);
> return virtio_net_guest_offloads_by_features(vdev->guest_features);
> --
> 2.25.1
>
- [PATCH v3 0/6] Vhost-vdpa Shadow Virtqueue Offloads support, Hawkins Jiawei, 2023/06/01
- [PATCH v3 1/6] include/hw/virtio: make some VirtIODevice const, Hawkins Jiawei, 2023/06/01
- [PATCH v3 2/6] vdpa: reuse virtio_vdev_has_feature(), Hawkins Jiawei, 2023/06/01
- [PATCH v3 3/6] hw/net/virtio-net: make some VirtIONet const, Hawkins Jiawei, 2023/06/01
- Re: [PATCH v3 3/6] hw/net/virtio-net: make some VirtIONet const,
Eugenio Perez Martin <=
- [PATCH v3 4/6] virtio-net: expose virtio_net_supported_guest_offloads(), Hawkins Jiawei, 2023/06/01
- [PATCH v3 5/6] vdpa: Add vhost_vdpa_net_load_offloads(), Hawkins Jiawei, 2023/06/01
- [PATCH v3 6/6] vdpa: Allow VIRTIO_NET_F_CTRL_GUEST_OFFLOADS in SVQ, Hawkins Jiawei, 2023/06/01
- Re: [PATCH v3 0/6] Vhost-vdpa Shadow Virtqueue Offloads support, Lei Yang, 2023/06/02