[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 01/11] *-user: remove the guest_user_syscall tracepoints
From: |
Stefan Hajnoczi |
Subject: |
[PULL v2 01/11] *-user: remove the guest_user_syscall tracepoints |
Date: |
Thu, 1 Jun 2023 11:06:39 -0400 |
From: Alex Bennée <alex.bennee@linaro.org>
This is pure duplication now. Both bsd-user and linux-user have
builtin strace support and we can also track syscalls via the plugins
system.
Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20230526165401.574474-2-alex.bennee@linaro.org
Message-Id: <20230524133952.3971948-2-alex.bennee@linaro.org>
[Remove unused variable in do_freebsd_syscall() reported by Richard
Henderson.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/user/syscall-trace.h | 4 ----
bsd-user/freebsd/os-syscall.c | 3 ---
trace-events | 19 -------------------
3 files changed, 26 deletions(-)
diff --git a/include/user/syscall-trace.h b/include/user/syscall-trace.h
index 90bda7631c..557f881a79 100644
--- a/include/user/syscall-trace.h
+++ b/include/user/syscall-trace.h
@@ -26,9 +26,6 @@ static inline void record_syscall_start(void *cpu, int num,
abi_long arg5, abi_long arg6,
abi_long arg7, abi_long arg8)
{
- trace_guest_user_syscall(cpu, num,
- arg1, arg2, arg3, arg4,
- arg5, arg6, arg7, arg8);
qemu_plugin_vcpu_syscall(cpu, num,
arg1, arg2, arg3, arg4,
arg5, arg6, arg7, arg8);
@@ -36,7 +33,6 @@ static inline void record_syscall_start(void *cpu, int num,
static inline void record_syscall_return(void *cpu, int num, abi_long ret)
{
- trace_guest_user_syscall_ret(cpu, num, ret);
qemu_plugin_vcpu_syscall_ret(cpu, num, ret);
}
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index c8f998ecec..de36c4b71c 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -528,10 +528,8 @@ abi_long do_freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
abi_long arg5, abi_long arg6, abi_long arg7,
abi_long arg8)
{
- CPUState *cpu = env_cpu(cpu_env);
abi_long ret;
- trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6,
arg7, arg8);
if (do_strace) {
print_freebsd_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
}
@@ -541,7 +539,6 @@ abi_long do_freebsd_syscall(void *cpu_env, int num,
abi_long arg1,
if (do_strace) {
print_freebsd_syscall_ret(num, ret);
}
- trace_guest_user_syscall_ret(cpu, num, ret);
return ret;
}
diff --git a/trace-events b/trace-events
index b6b84b175e..691c3533e4 100644
--- a/trace-events
+++ b/trace-events
@@ -85,22 +85,3 @@ vcpu guest_cpu_exit(void)
# Targets: all
vcpu guest_cpu_reset(void)
-# include/user/syscall-trace.h
-
-# @num: System call number.
-# @arg*: System call argument value.
-#
-# Start executing a guest system call in syscall emulation mode.
-#
-# Mode: user
-# Targets: TCG(all)
-vcpu guest_user_syscall(uint64_t num, uint64_t arg1, uint64_t arg2, uint64_t
arg3, uint64_t arg4, uint64_t arg5, uint64_t arg6, uint64_t arg7, uint64_t
arg8) "num=0x%016"PRIx64" arg1=0x%016"PRIx64" arg2=0x%016"PRIx64"
arg3=0x%016"PRIx64" arg4=0x%016"PRIx64" arg5=0x%016"PRIx64" arg6=0x%016"PRIx64"
arg7=0x%016"PRIx64" arg8=0x%016"PRIx64
-
-# @num: System call number.
-# @ret: System call result value.
-#
-# Finish executing a guest system call in syscall emulation mode.
-#
-# Mode: user
-# Targets: TCG(all)
-vcpu guest_user_syscall_ret(uint64_t num, uint64_t ret) "num=0x%016"PRIx64"
ret=0x%016"PRIx64
--
2.40.1
- [PULL v2 00/11] Tracing patches, Stefan Hajnoczi, 2023/06/01
- [PULL v2 02/11] trace-events: remove the remaining vcpu trace events, Stefan Hajnoczi, 2023/06/01
- [PULL v2 01/11] *-user: remove the guest_user_syscall tracepoints,
Stefan Hajnoczi <=
- [PULL v2 04/11] scripts/qapi: document the tool that generated the file, Stefan Hajnoczi, 2023/06/01
- [PULL v2 08/11] trace: remove control-vcpu.h, Stefan Hajnoczi, 2023/06/01
- [PULL v2 03/11] trace: remove vcpu_id from the TraceEvent structure, Stefan Hajnoczi, 2023/06/01
- [PULL v2 07/11] trace: remove code that depends on setting vcpu, Stefan Hajnoczi, 2023/06/01
- [PULL v2 10/11] hw/9pfs: use qemu_xxhash4, Stefan Hajnoczi, 2023/06/01
- [PULL v2 09/11] tcg: remove the final vestiges of dstate, Stefan Hajnoczi, 2023/06/01
- [PULL v2 11/11] accel/tcg: include cs_base in our hash calculations, Stefan Hajnoczi, 2023/06/01
- [PULL v2 05/11] docs/deprecated: move QMP events bellow QMP command section, Stefan Hajnoczi, 2023/06/01
- [PULL v2 06/11] qapi: make the vcpu parameters deprecated for 8.1, Stefan Hajnoczi, 2023/06/01
- Re: [PULL v2 00/11] Tracing patches, Richard Henderson, 2023/06/01